Review Request 129308: Calendar: clear selection on opening
David Edmundson
david at davidedmundson.co.uk
Wed Nov 2 13:53:51 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129308/#review100502
-----------------------------------------------------------
applets/digital-clock/package/contents/ui/CalendarView.qml (line 53)
<https://git.reviewboard.kde.org/r/129308/#comment67448>
This original code is trying to make sure we only reset once instead of twice as one will be wasteful.
Wouldn't changing it to if (isExpanded) work correctly too?
- David Edmundson
On Nov. 2, 2016, 12:30 a.m., Miklós Máté wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129308/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2016, 12:30 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> When opening the calendar popup of the digital clock plasmoid, the selection is on the day the popup was last opened -- possibly days or weeks ago. This patch fixes that.
>
>
> Diffs
> -----
>
> applets/digital-clock/package/contents/ui/CalendarView.qml 87c77da
>
> Diff: https://git.reviewboard.kde.org/r/129308/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Miklós Máté
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161102/96a4e348/attachment.html>
More information about the Plasma-devel
mailing list