Review Request 129309: Fix broken systemloadviewer tooltip

Miklós Máté mtmkls at gmail.com
Wed Nov 2 10:20:29 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129309/#review100492
-----------------------------------------------------------


Ship it!




Oh, you're right. I forgot to add this to my commit. Thanks for fixing it.

- Miklós Máté


On Nov. 2, 2016, 7:15 a.m., Antonio Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129309/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2016, 7:15 a.m.)
> 
> 
> Review request for Plasma, David Edmundson and Miklós Máté.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Commit 346b492 broke the systemloadviewer tooltip, it's trying to use a variable that is not defined.
> 
> 
> Diffs
> -----
> 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml bf299b7 
> 
> Diff: https://git.reviewboard.kde.org/r/129309/diff/
> 
> 
> Testing
> -------
> 
> Tooltip works again
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161102/b14516ae/attachment.html>


More information about the Plasma-devel mailing list