[Differential] [Updated] D3089: Restore global menu support

broulik (Kai Uwe Broulik) noreply at phabricator.kde.org
Wed Nov 2 09:42:41 UTC 2016


broulik marked 3 inline comments as done.
broulik added inline comments.

INLINE COMMENTS

> graesslin wrote in abstract_client.cpp:75-77
> why carry the bool in the signal? That seems to make it way more complicated here

In DecoratedClient I do

  connect(client, &AbstractClient::hasApplicationMenuChanged, decoratedClient, &KDecoration2::DecoratedClient::hasApplicationMenuChanged);

So either I need it here or there.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3089

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161102/03d23d09/attachment.html>


More information about the Plasma-devel mailing list