[Differential] [Changed Subscribers] D3200: Add a widget gallery page to the Dashboard.

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> DashboardRepresentation.qml:56
>      keyEventProxy: searchField
> +    backgroundColor: Qt.rgba(0, 0, 0, 0.737)
>  

any reason for the odd specificity of 0.737? and, seems an unrelated change with adding a widget gallery?

> DashboardRepresentation.qml:527
>                      onOpacityChanged: {
>                          if (opacity == 1.0) {
>                              mainColumn.visibleGrid = mainGrid;

this is not directly related to this review in particular but i see it in several places in this file and should be paid attention to: if the opacity is being animated, this line is going to be quite heavy, as well asproperty bindings on conditions on opacity, like for enabled and z just there, that would cause a lot of slot invocations during the animation, and is easily avoided.

> containmentinterface.h:52
> +        static Q_INVOKABLE QObject* screenContainment(QObject *appletInterface);
> +        static Q_INVOKABLE bool screenContainmentMutable(QObject *appletInterface);
> +        static Q_INVOKABLE void ensureMutable(Plasma::Containment *containment);

i think it could well use the immutability properties of plasmoid.. as it tries hard to have a single immutability for the whole shell (and i would like to keep it that way) tough if you feel safer to check the property on the final containment, fine

> dashboardwindow.h:52
>  
> +        QColor backgroundColor() const;
> +        void setBackgroundColor(const QColor &color);

seems an unrelated change?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3200

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161101/f87d28cf/attachment-0001.html>