Review Request 128040: [shellcorona] Containment can be nullptr

[Anthony Fieroni]

> On Май 30, 2016, 2:32 след обяд, Aleix Pol Gonzalez wrote:
> > Could you look a bit into why is the containment null?
> 
> Anthony Fieroni wrote:
>     So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i can't reproduce crash, KScreen is not finish recognazing, which i write above, corona.cpp:211 if (screen >= 0 && screen < numScreens()) is not satisfied for some reason and returning containment is nullptr. I can't figure out any other possible way.
> 
> Aleix Pol Gonzalez wrote:
>     But `createContainmentForActivity` should return a containment nevertheless, it's not related to KScreen after all.
> 
> Marco Martin wrote:
>     so may the issue go away with the port to qscreen?

createContainmentForActivity calls containmentForScreen() from corona which use numScreen() overridden in shellCorona and depend on KScreen configuration. So for me is KScreen related.


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/#review96027
-----------------------------------------------------------


On Май 30, 2016, 7:33 преди обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128040/
> -----------------------------------------------------------
> 
> (Updated Май 30, 2016, 7:33 преди обяд)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Bugs: 361548
>     https://bugs.kde.org/show_bug.cgi?id=361548
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> I can't reproduce this tons of bug reports and i event can't undertaind how containment can be nullptr, when i see corona.cpp http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447
> 
> 
> Diffs
> -----
> 
>   shell/shellcorona.cpp 2a78ca9 
> 
> Diff: https://git.reviewboard.kde.org/r/128040/diff/
> 
> 
> Testing
> -------
> 
> To stop crash ?!
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160530/6dee0a0a/attachment.html>