Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

[Wolfgang Bauer]

> On Mai 30, 2016, 2:35 nachm., David Faure wrote:
> > keditfiletype/mimetypewriter.cpp, line 155
> > <https://git.reviewboard.kde.org/r/128055/diff/1/?file=467290#file467290line155>
> >
> >     This could all be done with a single line,
> >     QDir().mkpath(packagesDirName);
> >     No need to check if it exists already, mkpath will do that for you anyway.

Good catch, thank you!
Didn't think of that somehow...


- Wolfgang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128055/#review96036
-----------------------------------------------------------


On Mai 30, 2016, 2:33 nachm., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128055/
> -----------------------------------------------------------
> 
> (Updated Mai 30, 2016, 2:33 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Faure.
> 
> 
> Bugs: 356237
>     https://bugs.kde.org/show_bug.cgi?id=356237
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> -------
> 
> QStandardDirs::writableLocation() doesn't guarantee that the returned directory actually exists.
> So check if it's there and create it if not, otherwise saving the changes will fail.
> 
> 
> Diffs
> -----
> 
>   keditfiletype/mimetypewriter.cpp 11963d2 
> 
> Diff: https://git.reviewboard.kde.org/r/128055/diff/
> 
> 
> Testing
> -------
> 
> Delete ~/.local/share/mime/packages/ or ~/.local/share/mime/, if they exist.
> Enter the file types editor and modify a file type (e.g. add/change the icon), then press OK or Apply.
> Close it and open it again.
> 
> The changes are still there now, before they were not applied and reverted to the system defaults.
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160530/692b5a0e/attachment.html>