[Differential] [Request, 42 lines] D1710: [server] Don't destroy ServerSideDecorationInterface when parent SurfaceInterface is destroyed

[graesslin (Martin Gräßlin)]

graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Destroying the ServerSideDecorationInterface on the server side before
  the client has a chance to cleanup results in a protocol error:
  wl_display at 1: error 0: invalid object 7
  
  Which would terminate the client. If we would not destroy the resource,
  but only delete the ServerSideDecorationInterface it could result in
  heap-use-after-free.
  
  So just don't do anything, the client needs to cleanup which will result
  in the ServerSideDecorationInterface being deleted.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  ssd-destroy-surface

REVISION DETAIL
  https://phabricator.kde.org/D1710

AFFECTED FILES
  autotests/client/test_server_side_decoration.cpp
  src/server/server_decoration_interface.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160530/17f2f67d/attachment.html>