[Differential] [Request, 42 lines] D1708: [server] Don't destroy BlurInterface when parent SurfaceInterface is destroyed

graesslin (Martin Gräßlin) noreply at phabricator.kde.org
Mon May 30 07:56:43 UTC 2016


graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Destroying the BlurInterface on the server side before the client has a
  chance to cleanup results in a protocol error:
  wl_display at 1: error 0: invalid object 7
  
  Which would terminate the client. If we would not destroy the resource,
  but only delete the BlurInterface it could result in heap-use-after-free.
  
  So just don't do anything, the client needs to cleanup which will result
  in the BlurInterface being deleted.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  blur-destroy-surface

REVISION DETAIL
  https://phabricator.kde.org/D1708

AFFECTED FILES
  autotests/client/test_wayland_blur.cpp
  src/server/blur_interface.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160530/a747775f/attachment.html>


More information about the Plasma-devel mailing list