Review Request 128040: [shellcorona] Containment can be nullptr

Anthony Fieroni bvbfan at abv.bg
Mon May 30 04:33:08 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/
-----------------------------------------------------------

(Updated Май 30, 2016, 7:33 преди обяд)


Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.


Changes
-------

Another approach, do not inser screen nor create view if containment is nullptr. This will not leave plasmashell in *incomplete* state and give a new chance for kscreen to identified the screen.


Bugs: 361548
    https://bugs.kde.org/show_bug.cgi?id=361548


Repository: plasma-workspace


Description
-------

I can't reproduce this tons of bug reports and i event can't undertaind how containment can be nullptr, when i see corona.cpp http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447


Diffs (updated)
-----

  shell/shellcorona.cpp 2a78ca9 

Diff: https://git.reviewboard.kde.org/r/128040/diff/


Testing
-------

To stop crash ?!


Thanks,

Anthony Fieroni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160530/e8e9158e/attachment.html>


More information about the Plasma-devel mailing list