[Differential] [Request, 4 lines] D1706: [Switch Window Containment Action] Fix listing windows with just one virtual desktop

broulik (Kai Uwe Broulik) noreply at phabricator.kde.org
Sun May 29 17:39:55 UTC 2016


broulik created this revision.
broulik added reviewers: Plasma, hein, graesslin.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When there is only one virtual desktop, TasksModel DesktopRole returns 0 instead of 1, so we never listed windows in this case.
  
  BUG: 363656
  FIXED-IN: 5.6.5

TEST PLAN
  Seems to work.
  
  I don't understand why the model does that, though:
  
    int Task::desktop() const
    {
        if (KWindowSystem::numberOfDesktops() < 2) {
            return 0;
        }
    
        return d->info.desktop();
    }

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1706

AFFECTED FILES
  containmentactions/switchwindow/switch.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, hein, graesslin
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160529/73f22361/attachment.html>


More information about the Plasma-devel mailing list