Review Request 128040: [shellcorona] Containment can be nullptr

[Anthony Fieroni]

> On Май 29, 2016, 6:30 след обяд, Kai Uwe Broulik wrote:
> > shell/shellcorona.cpp, line 907
> > <https://git.reviewboard.kde.org/r/128040/diff/1/?file=467215#file467215line907>
> >
> >     I think we need to figure out *why* containment is null, this assert is probably there for a reason.
> 
> Anthony Fieroni wrote:
>     For me, the problem is kscreen. shellcorona.cpp:631 numScreens returns 0 cause kscreen not finish initializing who reflect on corona.cpp:211 if (screen >= 0 && screen < numScreens()) so returning containment is nullptr. Possible fix can be to wait kscreen to finish.
> 
> Kai Uwe Broulik wrote:
>     https://git.reviewboard.kde.org/r/125451/ Or that :)

I saw this, but it's waiting for minimum depends to be Qt 5.6? So maybe we can provide some patch till it happend? I think it can be ugly but users will be happy, almost :)


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/#review95983
-----------------------------------------------------------


On Май 29, 2016, 8:17 преди обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128040/
> -----------------------------------------------------------
> 
> (Updated Май 29, 2016, 8:17 преди обяд)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Bugs: 361548
>     https://bugs.kde.org/show_bug.cgi?id=361548
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> I can't reproduce this tons of bug reports and i event can't undertaind how containment can be nullptr, when i see corona.cpp http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447
> 
> 
> Diffs
> -----
> 
>   shell/shellcorona.cpp 2a78ca9 
> 
> Diff: https://git.reviewboard.kde.org/r/128040/diff/
> 
> 
> Testing
> -------
> 
> To stop crash ?!
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160529/48f13b32/attachment-0001.html>