Review Request 128038: [libtaskmanager] Stop highlighted window effect when close window in group item

Anthony Fieroni bvbfan at abv.bg
Sat May 28 20:13:59 UTC 2016



> On Май 28, 2016, 10:35 след обяд, Eike Hein wrote:
> > The description is insufficient. If it works, why is this necessary? What differences does it make? What is it trying to achieve?

Activate works because of kwin, closing not works. It is correct to me, that code to present. So if you don't want it, i can revert code on activate window. On close window must stay.


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128038/#review95957
-----------------------------------------------------------


On Май 28, 2016, 10:19 след обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128038/
> -----------------------------------------------------------
> 
> (Updated Май 28, 2016, 10:19 след обяд)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> 1. Enable highlighted window, tooltips and grouping
> 2. Open more then one in goup
> 3. Close one of grouped windows by click at tooltip button
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/plugin/backend.cpp afc6b91c0f492565b76a0a01e042ca7acbdbc0b4 
> 
> Diff: https://git.reviewboard.kde.org/r/128038/diff/
> 
> 
> Testing
> -------
> 
> Activate window "works" because kwin stops effect on activate, however it better to be stopped.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160528/6939e7cd/attachment.html>


More information about the Plasma-devel mailing list