Review Request 128030: [libtaskamanger] Dismiss context menu when window is closed

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128030/#review95938
-----------------------------------------------------------



Meh. I thought I tested it thoroughly enough when switching from QMetaObject::invokeMethod to QTimer::singleShot(0 ...

Isn't it sufficient to just cache the QQuickWindow pointer in a variable and pass that into the lamda, rather than doing item->window() ? It's not like the *window* the task manager is in (ie. the panel) goes away:

QQuickWindow *w = item->window()
QTimer::singleShot(blabla, [=] {
    m_menu->setTransientParent(w);
});

- Kai Uwe Broulik


On Mai 28, 2016, 12:07 nachm., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128030/
> -----------------------------------------------------------
> 
> (Updated Mai 28, 2016, 12:07 nachm.)
> 
> 
> Review request for Plasma, David Edmundson and Eike Hein.
> 
> 
> Bugs: 362713
>     https://bugs.kde.org/show_bug.cgi?id=362713
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Window can be close externally and this cause context menu to became dangerous
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://git.reviewboard.kde.org/r/128030/diff/
> 
> 
> Testing
> -------
> 
> It looks to work, need test from reporters
> NB: I don't know why reviewboard reject patch format. (diff cannot be parsed)
> 
> 
> File Attachments
> ----------------
> 
> backend.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/28/9a414f0b-af7e-4a34-b651-586af7ba298b__backend.patch
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160528/0ad8de04/attachment.html>