Review Request 128030: [libtaskamanger] Dismiss context menu when window is closed

[Anthony Fieroni]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128030/
-----------------------------------------------------------

(Updated Май 28, 2016, 3:07 след обяд)


Review request for Plasma, David Edmundson and Eike Hein.


Changes
-------

Cache window to smart pointer to care it. Add checks before use it, for any case. Backtrace problem line is *m_contextMenu->windowHandle()->setTransientParent*


Bugs: 362713
    https://bugs.kde.org/show_bug.cgi?id=362713


Repository: plasma-workspace


Description
-------

Window can be close externally and this cause context menu to became dangerous


Diffs
-----


Diff: https://git.reviewboard.kde.org/r/128030/diff/


Testing (updated)
-------

It looks to work, need test from reporters
NB: I don't know why reviewboard reject patch format. (diff cannot be parsed)


File Attachments (updated)
----------------

backend.patch
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/28/9a414f0b-af7e-4a34-b651-586af7ba298b__backend.patch


Thanks,

Anthony Fieroni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160528/45401e66/attachment.html>