Review Request 128033: Add kcon to systemsettings
David Edmundson
david at davidedmundson.co.uk
Sat May 28 11:43:10 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128033/#review95935
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On May 28, 2016, 9:38 a.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128033/
> -----------------------------------------------------------
>
> (Updated May 28, 2016, 9:38 a.m.)
>
>
> Review request for Plasma and Christoph Feck.
>
>
> Bugs: 347028
> http://bugs.kde.org/show_bug.cgi?id=347028
>
>
> Repository: kcron
>
>
> Description
> -------
>
> 1) kcm_cron.desktop has X-KDE-System-Settings-Parent-Category=system-administration,
> but there is no category system-administration in systemsettings5
> changed this to systemsettings5 category session as already patch by debian
>
> 2) kcron is a kcm, therefore the docbook should be installed in subdir kcontrol like all other kcm docbooks
>
>
> Diffs
> -----
>
> doc/CMakeLists.txt 7a0696c
> src/kcm_cron.desktop 3bd6c81
>
> Diff: https://git.reviewboard.kde.org/r/128033/diff/
>
>
> Testing
> -------
>
> shows up in systemsettings5
>
>
> Thanks,
>
> Burkhard Lück
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160528/204eabbd/attachment-0001.html>
More information about the Plasma-devel
mailing list