Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell
Johannes Huber
johu at gentoo.org
Thu May 26 20:24:48 UTC 2016
> On April 29, 2016, 4:06 nachm., David Edmundson wrote:
> > lets get this merged ASAP so we have some time to fix any fallout from it.
>
> Sebastian Kügler wrote:
> But we don't depend on Qt 5.6 yet in workspace. I think the blocker there is that we need Qt 5.6 on the CI system, then we can switch. Incidentally, Qt 5.6 on Plasma Mobile is also getting closer, which I think is also a good thing to have in line.
>
> David Edmundson wrote:
> https://build.kde.org/view/QT/job/qt5%205.6%20kf5-qt5/ we have Qt5.6 on CI
>
> Sebastian Kügler wrote:
> I'm personally fine with it, but Martin has a point:
>
> <sebas> other thing: should we bump dependency of workspace to Qt 5.6 now that it's on CI?
> <mgraesslin> sebas: my point still holds: not before there is a release which actually works
> <sebas> for master?
> <mgraesslin> yes, even for master
> <sebas> that does not matter, assuming they'll ever fix it
> <mgraesslin> I don't want us to release Plasma 5.7 befor Qt 5.6.1 is out
> <sebas> arguably, 5.6 works better in some areas than 5.5
> <mgraesslin> Qt 5.6.0 doesn't even start
> <sebas> what's still broken though?
> <mgraesslin> 5.6.0 released with a dbus deadlock in kded
> <mgraesslin> one cannot start a Plasma session without a patched Qt
> <sebas> ah, and patch is in Qt 5.6 branch, but not 5.6.0?
> <mgraesslin> yes
> <sebas> k, thanks
> -*- sebas replies to David then
>
> ... so, wait until Qt 5.6.1 is out?
FYI http://lists.qt-project.org/pipermail/releasing/2016-May/004280.html
- Johannes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125451/#review95021
-----------------------------------------------------------
On März 17, 2016, 2:02 vorm., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125451/
> -----------------------------------------------------------
>
> (Updated März 17, 2016, 2:02 vorm.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Now that everything's in place in Qt, we can do that.
>
> It basically removes all the translation layer between KScreen and QScreen.
>
> NOTE: This can't be merged until Qt 5.6 is a dependency.
>
>
> Diffs
> -----
>
> CMakeLists.txt d407aed
> shell/CMakeLists.txt 7082f32
> shell/panelview.h 1837f96
> shell/panelview.cpp c8c3c71
> shell/shellcorona.h 271d7bf
> shell/shellcorona.cpp 50125bb
>
> Diff: https://git.reviewboard.kde.org/r/125451/diff/
>
>
> Testing
> -------
>
> Hands-on testing, it's been working quite fluid and I couldn't find a crash. (There could be crashes, I just didn't find them :D)
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160526/3da40b48/attachment-0001.html>
More information about the Plasma-devel
mailing list