[Differential] [Accepted] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

[sebas (Sebastian Kügler)]

sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision is now accepted and ready to land.


  looks good to me

INLINE COMMENTS

> integration.cpp:46
> +#include <qpa/qplatforminputcontext.h>
> +#include <qpa/qplatforminputcontextfactory_p.h>
> +#include <qpa/qwindowsysteminterface.h>

cross fingers?

> inputmethodstest.qml:82
> +    TextField {
> +        inputMethodHints: Qt.ImhTime
> +    }

DateTime and Terminal missing?

> virtualkeyboard.cpp:55
> +{
> +    // this is actually to late. Other processes are started before init,
> +    // so might miss the availability of text input

too late

REPOSITORY
  rKWIN KWin

BRANCH
  virtual-keyboard

REVISION DETAIL
  https://phabricator.kde.org/D1638

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: sebas, mart, broulik, plasma-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160525/99e6ff12/attachment.html>