[Differential] [Accepted] D1678: Add ScrollArea to events view in calendar

broulik (Kai Uwe Broulik) noreply at phabricator.kde.org
Wed May 25 08:51:51 UTC 2016


broulik accepted this revision.
broulik added a reviewer: broulik.
broulik added a comment.
This revision is now accepted and ready to land.


  Please put the wrapping/spacing stuff into a separate commit. Thanks!

INLINE COMMENTS

> CalendarView.qml:153
>              }
> +            flickableItem.boundsBehavior: Flickable.StopAtBounds;
>  

no semicolon

> CalendarView.qml:157
> +                id: holidaysList
> +                anchors.fill: parent
>  

I don't think this is needed

> CalendarView.qml:196
> +                        wrapMode: Text.Wrap
> +                        verticalAlignment: Text.AlignTop
>                      }

Isn't this the default?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  calendar-scrollview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D1678

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, broulik
Cc: broulik, plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160525/245833ca/attachment-0001.html>


More information about the Plasma-devel mailing list