[Differential] [Commented On] D1676: kfontinst: Port to QApplication and QCommandLineParser

apol (Aleix Pol Gonzalez) noreply at phabricator.kde.org
Tue May 24 18:16:36 UTC 2016


apol added a comment.


  LGTM +1

INLINE COMMENTS

> Viewer.cpp:131
>          {
> -            for (int i = 0; i < args->count(); ++i)
> +            for (int i = 0; i < urlArgs.count(); ++i)
>              {

Prefer foreach to iterate a QList

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1676

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volkov, Plasma
Cc: apol, plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160524/6af94655/attachment.html>


More information about the Plasma-devel mailing list