Review Request 128001: [Quick Chat] Close chat window when pressing Escape

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128001/#review95739
-----------------------------------------------------------


Ship it!




Ship It!

- David Edmundson


On May 24, 2016, 9:40 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128001/
> -----------------------------------------------------------
> 
> (Updated May 24, 2016, 9:40 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> When pressing Escape, first the text field is cleared, and if it's empty it will close the chat view
> 
> 
> Diffs
> -----
> 
>   chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml 4e802c7 
> 
> Diff: https://git.reviewboard.kde.org/r/128001/diff/
> 
> 
> Testing
> -------
> 
> Typed some text, pressed Escape, text was cleared. Pressed Escape again, window closed.
> 
> Opened window, typed nothing, pressed Escape, window closed as expected.
> 
> Makes using the quick chat using with just the keyboard less annoying.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160524/822abf54/attachment.html>