Review Request 127975: selected state for Plasma::Svg and PlasmaCore::IconItem

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127975/
-----------------------------------------------------------

(Updated May 24, 2016, 8:30 a.m.)


Review request for Plasma.


Changes
-------

version with an enum instead of bool


Repository: plasma-framework


Description
-------

Like KIconloader, support a Selected state, in IconItem, as in all generic svgs/framesvg
it replaces the text color with HighlightedText and the background color with HighlightColor


Diffs (updated)
-----

  src/declarativeimports/core/framesvgitem.h 335a9b4 
  src/declarativeimports/core/framesvgitem.cpp 1bde3d2 
  src/declarativeimports/core/iconitem.h 38a9c7a 
  src/declarativeimports/core/iconitem.cpp 12008f8 
  src/plasma/private/svg_p.h 6f1efc2 
  src/plasma/private/theme_p.h 945fcef 
  src/plasma/private/theme_p.cpp 99e865b 
  src/plasma/svg.h 3a4ca1d 
  src/plasma/svg.cpp 507ed75 
  src/plasma/theme.cpp 3b7b371 
  tests/selected_svg.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127975/diff/


Testing
-------


File Attachments
----------------

showing a framesvg, a SvgItem and an IconItem
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/20/27777434-baf4-45d2-9f26-71b4b857502d__dadel4.png


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160524/e0caf837/attachment-0001.html>