Review Request 127971: [KToolBar] Disable toggleViewAction() when actions/options_show_toolbar is restricted

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127971/#review95698
-----------------------------------------------------------


Fix it, then Ship it!




Looks fine to me, except for the reasoning in the commit log. It's perfectly fine to reimplement an existing virtual method from a base class into a derived class, this doesn't break ABI.


autotests/ktoolbar_unittest.cpp (line 657)
<https://git.reviewboard.kde.org/r/127971/#comment64792>

    better written as QVERIFY(!...)


- David Faure


On May 19, 2016, 9:37 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127971/
> -----------------------------------------------------------
> 
> (Updated May 19, 2016, 9:37 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> While KXmlGui makes sure to prevent the user from hiding toolbars when not allowed, right-clicking an empty space in a QMainWindow, such as the menu bar, will yield a menu created by Qt, which knows nothing about Kiosk restrictions, listing all toolbar toggle actions of this window.
> 
> 
> Diffs
> -----
> 
>   autotests/ktoolbar_unittest.cpp d6c1e05 
>   src/ktoolbar.cpp 8fcb9cb 
> 
> Diff: https://git.reviewboard.kde.org/r/127971/diff/
> 
> 
> Testing
> -------
> 
> Comes with a unittest.
> 
> I can no longer hide the main toolbar in Dolphin or Gwenview when this action is restricted by simply right-clicking the menu bar.
> 
> 
> File Attachments
> ----------------
> 
> The Menu
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/19/076745b4-03a2-400f-9506-46999d4ce1e1__toolbartoggle.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160522/2b36c1f4/attachment.html>