Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

Matthias Blaicher matthias at blaicher.com
Sat May 21 07:26:29 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125451/#review95666
-----------------------------------------------------------


Ship it!




Hello Aleix,
I've just applied this patch and it fixed all my multi-screen/laptop/docking issues! You literally saved my relationship! (Gf switch her laptop to plasma 5 and was constantly cursing)

- Matthias Blaicher


On March 17, 2016, 1:02 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125451/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 1:02 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Now that everything's in place in Qt, we can do that.
> 
> It basically removes all the translation layer between KScreen and QScreen.
> 
> NOTE: This can't be merged until Qt 5.6 is a dependency.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d407aed 
>   shell/CMakeLists.txt 7082f32 
>   shell/panelview.h 1837f96 
>   shell/panelview.cpp c8c3c71 
>   shell/shellcorona.h 271d7bf 
>   shell/shellcorona.cpp 50125bb 
> 
> Diff: https://git.reviewboard.kde.org/r/125451/diff/
> 
> 
> Testing
> -------
> 
> Hands-on testing, it's been working quite fluid and I couldn't find a crash. (There could be crashes, I just didn't find them :D)
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160521/37136764/attachment.html>


More information about the Plasma-devel mailing list