[Differential] [Commented On] D1647: kfontinst: Port to QDialog

[volkov (Alexander Volkov)]

volkov added inline comments.

INLINE COMMENTS

> apol wrote in Printer.cpp:349
> Pass this as the last argument, so it has a parent and doesn't leak. On this one and the rest of `new QDialogButtonBox`.

There is no need to set a parent in the constructor. QLayout::addWidget() will do it later.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1647

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volkov, Plasma
Cc: apol, plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160520/b81965a5/attachment.html>