[Differential] [Request, 125 lines] D1644: Enforce options_show_toolbar for QToolBar toggleViewAction

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAINTEGRATION Integration for Qt applications in Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  While KXmlGui makes sure to prevent the user from hiding toolbars when not allowed,
  when right-clicking an empty space in a QMainWindow, such as the menu bar, will yield
  a menu created by Qt, which knows nothing about Kiosk restrictions, listing all toolbar
  toggle actions of this window.

TEST PLAN
  I can no longer hide the main toolbar in Dolphin or Gwenview.
  
  See comment in the code for an explanation what it actually does :)
  In principle we could also think of enforcing other KAuthorized stuff here but both KXmlGui and KActionCollection take care of most of it.
  
  How can I simulate the KAuthorized stuff for an autotest? Is there a KConfig kdeglobals test mode or something like that?

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D1644

AFFECTED FILES
  autotests/CMakeLists.txt
  src/platformtheme/CMakeLists.txt
  src/platformtheme/kdeplatformtheme.cpp
  src/platformtheme/kdeplatformtheme.h
  src/platformtheme/kioskintegration.cpp
  src/platformtheme/kioskintegration.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160519/28a3327e/attachment-0001.html>