[Differential] [Request, 5 lines] D1641: Don't update decoration when ServerSideDecoration gets destroyed and ShellClient is unmapped
graesslin (Martin Gräßlin)
noreply at phabricator.kde.org
Thu May 19 14:42:33 UTC 2016
graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Most likely the window is in the process of getting destroyed. In that
case the following destroy of the Surface is also going to destroy the
decoration.
This was causing an interesting effect with the QQuickRenderControl used
by Aurorae. When getting destroyed it ensures that all posted events get
processed. This includes the destroy of the Surface which entered
ShellClient::destroyClient which again destroyed the decoration. In other
words a recursive destroy which ended with wonderful crashers due to
double deletions.
If the window is not unmapped this might still cause problems: more
testing needed.
REPOSITORY
rKWIN KWin
BRANCH
deco-destroy-shell-cleint
REVISION DETAIL
https://phabricator.kde.org/D1641
AFFECTED FILES
shell_client.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, Plasma
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160519/35132169/attachment.html>
More information about the Plasma-devel
mailing list