Review Request 127909: [AppletInterface] Expose immutability

Marco Martin notmart at gmail.com
Thu May 19 14:22:59 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127909/#review95611
-----------------------------------------------------------


Fix it, then Ship it!





src/scriptengines/qml/plasmoid/appletinterface.h (line 159)
<https://git.reviewboard.kde.org/r/127909/#comment64768>

    maybe add:
    use this if you need a more granular control than just using the immutable property
    @see immutable


- Marco Martin


On May 13, 2016, 5:44 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127909/
> -----------------------------------------------------------
> 
> (Updated May 13, 2016, 5:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This allows an applet to query whether widgets are user-locked or locked down by Kiosk restrictions.
> 
> In the latter case, Kickoff for instance could disallow re-arranging, adding, or removing favorites, or hide the kmenuedit shortcut.
> 
> 
> Diffs
> -----
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 6cf71aa 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 876af2c 
> 
> Diff: https://git.reviewboard.kde.org/r/127909/diff/
> 
> 
> Testing
> -------
> 
> plasmoid.immutability === PlasmaCore.Types.SystemImmutable works nicely in Kickoff. Usually you just need plasmoid.immutable, so we shouldn't deprecate it and incourage that one, except you really want to lock it down in SystemImmutable mode
> 
> I'm open to suggestions on better wording in the docs
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160519/d2559d82/attachment.html>


More information about the Plasma-devel mailing list