Review Request 127946: [KDeclarative] [KCMShell] Add "authorized" wrapper around KAuthorize::authorizeControlModules

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127946/
-----------------------------------------------------------

(Updated May 18, 2016, 5:43 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit cee0c38ca3e11803b2b694300c98a212be6df76f by Kai Uwe Broulik to branch master.


Repository: kdeclarative


Description
-------

This allows to hide a configure button if the resulting click would do nothing due to KIOSK restrictions.


Diffs
-----

  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt be2d534 
  src/qmlcontrols/kquickcontrolsaddons/kcmshell.h 7436aba 
  src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp af2e639 

Diff: https://git.reviewboard.kde.org/r/127946/diff/


Testing
-------

If I disable all kcms for powermanagement I now longer get a "Configure Power saving", obviously the applets need to be adjusted but we should do that for the default setup.

Not sure about the API, though, makes it a bit cumbersome to use. Perhaps we need a shortcut like KAuthorized has where you just do if (authorize("foo")) and done? Would also save costly conversions between C++ and QML types. I'm open to suggestions :)

Supposedly you can just do foo("bar") instead of foo(["bar"]) for QStringList args and it will implicitly convert it for you but I don't trust that

Also all the "Kconfig found" cmake checks all over the place are rather superfluous as it's a required dep for kdeclarative


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160518/92c2d27b/attachment.html>