[Differential] [Commented On] D1631: Implement wl_text_input and zwp_text_input_v2 interfaces

[graesslin (Martin Gräßlin)]

graesslin added a comment.


  Sorry for the large review. The fact that it supports two interfaces made it rather complex.
  
  When reviewing please check whether the exposed methods sound good, are well documented, etc. Please also verify whether the implementation actually matches what is described in the two xml protocols.

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1631

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160518/45696864/attachment.html>