Review Request 127947: [ContainmentInterface] Don't try to popup empty QMenu
Marco Martin
notmart at gmail.com
Wed May 18 08:46:48 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127947/#review95574
-----------------------------------------------------------
Ship it!
always accept
- Marco Martin
On May 17, 2016, 6:32 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127947/
> -----------------------------------------------------------
>
> (Updated May 17, 2016, 6:32 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> With KIOSK restrictions it can happen that a context menu would be empty. In this case just a shadow would show up. Do nothing in this case.
>
>
> Diffs
> -----
>
> src/scriptengines/qml/plasmoid/containmentinterface.cpp f168002
>
> Diff: https://git.reviewboard.kde.org/r/127947/diff/
>
>
> Testing
> -------
>
> AppletInterface already has similar code.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160518/ab305c71/attachment-0001.html>
More information about the Plasma-devel
mailing list