Review Request 127918: Cleanup and fixup KConfig handling for componentchooser

Hrvoje Senjan hrvoje.senjan at gmail.com
Tue May 17 20:19:35 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127918/
-----------------------------------------------------------

(Updated May 17, 2016, 8:19 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and David Faure.


Changes
-------

Submitted with commit 27ebf75bd44101976d8392eec4ff4d20f495fb69 by Hrvoje Senjan to branch Plasma/5.6.


Repository: plasma-desktop


Description
-------

Address David's issues in previous rr's regarding the code.


Diffs
-----

  kcms/componentchooser/componentchooserbrowser.cpp 5795c2b 
  kcms/componentchooser/componentchooserfilemanager.cpp a04cced 
  kcms/componentchooser/componentchooserterminal.cpp 36f1296 
  kcms/input/mouse.cpp f7d030f 
  kcms/migrationlib/kdelibs4config.h bb2dca2 

Diff: https://git.reviewboard.kde.org/r/127918/diff/


Testing
-------

Default browser is correctly written in both ~/.kde4/share/config/kdeglobals and ~/.config/kdeglobals


Thanks,

Hrvoje Senjan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160517/325b79df/attachment-0001.html>


More information about the Plasma-devel mailing list