Review Request 127937: Use SAX instead of DOM for Plasma::Svg stylesheet replacement

Marco Martin notmart at gmail.com
Tue May 17 12:45:56 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127937/
-----------------------------------------------------------

(Updated May 17, 2016, 12:45 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit f98cae5dd051cff71a97e0ca6d5a5858bd2e9c1a by Marco Martin to branch master.


Repository: plasma-framework


Description
-------

following KIconLoader, use QXmlStreamReader/Writer here too to replace the svg stylesheet to color the svg with system colors.
it should be hopefully slightly more efficient


Diffs
-----

  src/plasma/svg.cpp 4538ad0 

Diff: https://git.reviewboard.kde.org/r/127937/diff/


Testing
-------

plasma themes load fine and apply system colors correctly


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160517/0c3fa48a/attachment.html>


More information about the Plasma-devel mailing list