[Differential] [Request, 1 line] D1623: [client] Don't delete windows from PlasmaWindowModel

graesslin (Martin Gräßlin) noreply at phabricator.kde.org
Tue May 17 07:43:57 UTC 2016


graesslin created this revision.
graesslin added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  So far when the PlasmaWindowManagement went down the PlasmaWindowModel
  deleted all windows. This is not needed as the PlasmaWindow has the
  PlasmaWindowManagement as parent, so it will be destroyed anyway.
  
  The delete in PlasmaWindowModel risks that other signals connecting
  to the same signal will operate on deleted data, which they did not
  expect. So it's better to not delete here and let the later auto
  delete handle it.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  dont-delete-window-from-model

REVISION DETAIL
  https://phabricator.kde.org/D1623

AFFECTED FILES
  src/client/plasmawindowmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, hein
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160517/539d3b81/attachment.html>


More information about the Plasma-devel mailing list