Review Request 127918: Cleanup and fixup KConfig handling for componentchooser
Hrvoje Senjan
hrvoje.senjan at gmail.com
Mon May 16 20:52:49 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127918/
-----------------------------------------------------------
(Updated May 16, 2016, 10:52 p.m.)
Review request for Plasma and David Faure.
Changes
-------
Update code touched by me in previous commits wrt SimpleConfig. Mouse.cpp is now ugly, but unfortunately necessary to avoid the kconfig bug.
Repository: plasma-desktop
Description
-------
Address David's issues in previous rr's regarding the code.
Diffs (updated)
-----
kcms/componentchooser/componentchooserbrowser.cpp 5795c2b
kcms/componentchooser/componentchooserterminal.cpp 36f1296
kcms/input/mouse.cpp f7d030f
kcms/migrationlib/kdelibs4config.h bb2dca2
Diff: https://git.reviewboard.kde.org/r/127918/diff/
Testing
-------
Default browser is correctly written in both ~/.kde4/share/config/kdeglobals and ~/.config/kdeglobals
Thanks,
Hrvoje Senjan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160516/8e7cab0c/attachment.html>
More information about the Plasma-devel
mailing list