Review Request 127937: Use SAX instead of DOM for Plasma::Svg stylesheet replacement

Mark Gaiser markg85 at gmail.com
Mon May 16 10:07:42 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127937/#review95504
-----------------------------------------------------------



Could you please benchmark this to make sure it's faster?
Performance optimizations should always be benchmarked to make sure you're not decreasing performance instead ;)

- Mark Gaiser


On mei 16, 2016, 9:36 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127937/
> -----------------------------------------------------------
> 
> (Updated mei 16, 2016, 9:36 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> following KIconLoader, use QXmlStreamReader/Writer here too to replace the svg stylesheet to color the svg with system colors.
> it should be hopefully slightly more efficient
> 
> 
> Diffs
> -----
> 
>   src/plasma/svg.cpp 4538ad0 
> 
> Diff: https://git.reviewboard.kde.org/r/127937/diff/
> 
> 
> Testing
> -------
> 
> plasma themes load fine and apply system colors correctly
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160516/791e0cc7/attachment.html>


More information about the Plasma-devel mailing list