Review Request 123281: Avoid triggering bug 340691

[Hrvoje Senjan]

> On May 13, 2016, 8:43 p.m., David Faure wrote:
> > kcms/migrationlib/kdelibs4config.h, line 28
> > <https://git.reviewboard.kde.org/r/123281/diff/1/?file=360341#file360341line28>
> >
> >     I just noticed a compiler warning in this method: the "mode" argument isn't used. This part of the commit can't possibly have changed anything, then.
> >     Either it should actually be used, or it should be removed. Otherwise it's just confusing, as this patch shows....

You're right.  Furthermore, the bug is about the source, not the target.


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123281/#review95454
-----------------------------------------------------------


On April 7, 2015, 1:46 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123281/
> -----------------------------------------------------------
> 
> (Updated April 7, 2015, 1:46 p.m.)
> 
> 
> Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> With Kdelibs4Migration we know exactly which file to modify, so it is both correct to use KConfig::SimpleConfig, and should help avoiding triggering the mentioned bug.
> As similar fix was applied for bug 343583.
> 
> 
> Diffs
> -----
> 
>   kcms/icons/icons.cpp 16a3141 
>   kcms/migrationlib/kdelibs4config.h 0c1b7fe 
> 
> Diff: https://git.reviewboard.kde.org/r/123281/diff/
> 
> 
> Testing
> -------
> 
> Changed the default browser in systemsettings5, the config got written in both ~/.config/kdeglobals and ~/.kde4/share/config/kdeglobals
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160514/b0343c31/attachment.html>