Review Request 127899: [KCMShell] Honor KAuthorized restrictions

[David Edmundson]

> On May 12, 2016, 3:59 p.m., David Edmundson wrote:
> > kcmshell/main.cpp, line 95
> > <https://git.reviewboard.kde.org/r/127899/diff/1/?file=464663#file464663line95>
> >
> >     this line is already doing it.
> >     
> >     bool KService::noDisplay() const
> >     ...
> >         if (!KAuthorized::authorizeControlModule(storageId())) {
> >             return true;
> >         }

I'm a bit confused. You said "you could still open them" but you've also written you've not tested it.

If you have tried blocking it them and it's not working, can you show me your config file?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127899/#review95424
-----------------------------------------------------------


On May 12, 2016, 1:59 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127899/
> -----------------------------------------------------------
> 
> (Updated May 12, 2016, 1:59 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> -------
> 
> This makes KCMShell skip loading modules that are restricted in KDE Control Module Restrictions.
> 
> The --list property already filtered them but you could still open them.
> 
> 
> Diffs
> -----
> 
>   kcmshell/main.cpp 3a4f651 
> 
> Diff: https://git.reviewboard.kde.org/r/127899/diff/
> 
> 
> Testing
> -------
> 
> Literally none.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160512/93fab1b7/attachment.html>