Review Request 127878: use the "selected" icon mode in file open dialog sidebar

[Marco Martin]

> On May 11, 2016, 11:03 a.m., David Edmundson wrote:
> > src/widgets/kfileitemdelegate.cpp, line 1220
> > <https://git.reviewboard.kde.org/r/127878/diff/2/?file=464577#file464577line1220>
> >
> >     QCommonStyle when rendering CE_ItemViewItem checks for disabled first
> >     
> >     QIcon::Mode mode = QIcon::Normal;
> >     if (!(vopt->state & QStyle::State_Enabled))
> >     mode = QIcon::Disabled;
> >     else if (vopt->state & QStyle::State_Selected)
> >                     mode = QIcon::Selected;
> >                     
> >     qcommonstyle:2167
> >                     
> >     it's probably best to emulate that
> >     
> >     
> >     also why do you have the && active?
> >     
> >     That means it'd need to be both selected and have mouse over at the same time in order to change icon?

yes, it changes the color only on active palette, changing it on inactive palette doesn't look really good.

unfortunately can't really pass the palette state to the iconloader, so when recoloring is always using the active palette, not doing the invert (that would be with active colors) on inactive palette seems to be the way that looks less bad


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127878/#review95382
-----------------------------------------------------------


On May 10, 2016, 11:57 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127878/
> -----------------------------------------------------------
> 
> (Updated May 10, 2016, 11:57 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> since now kiconloader can color the icons in the sidebar, by using the "selected" icon mode, when the breeze icon theme is used the icon of the current sidebar item will be of the same color of selected text (white-ish by default), is more in line with breeze style and the monochrome icons become more readable
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/kfileplacesview.cpp 03074e0 
>   src/widgets/kfileitemdelegate.cpp 1516b9e 
> 
> Diff: https://git.reviewboard.kde.org/r/127878/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> menu3.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/41f52d86-6fc5-4799-bd9e-18d17dc5a65a__menu3.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160512/9cd8f7dd/attachment.html>