Review Request 127893: [DialogShadows] Cache access to QX11Info::display()

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127893/#review95385
-----------------------------------------------------------


Ship it!




this code looks awfully familiar to something I just reviewed...

- David Edmundson


On May 11, 2016, 5:24 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127893/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 5:24 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> It's called several times and even in a loop.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialogshadows.cpp 95d5bc0 
> 
> Diff: https://git.reviewboard.kde.org/r/127893/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160511/162d38c2/attachment.html>