Review Request 127842: take highlight and highlightedText from proper color group

[Kai Uwe Broulik]

> On Mai 5, 2016, 8:02 nachm., Kai Uwe Broulik wrote:
> > Switching themes no longer properly updates the highlight color, ie. switching from Breeze to Honeycomb leaves me with a blue highlight (and brokenness in task manager with yellow borders around blue items). Then switching to another theme leaves me with the previous highlight, ie. yellow in this case no matter the color I chose. Something's broken now.
> 
> Kai Uwe Broulik wrote:
>     And also selected text is now black on blue rather than white on blue like before and like in widgets applications
> 
> Marco Martin wrote:
>     should be fixed in http://commits.kde.org/plasma-framework/2b7543c34381d81027b66018a6e021c74848fb75

Thanks. Which color are the sliders using? They also use the faint blue, progress bars are fine though (in normal color group, in complementary they are also faint)


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127842/#review95212
-----------------------------------------------------------


On Mai 5, 2016, 10:22 vorm., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127842/
> -----------------------------------------------------------
> 
> (Updated Mai 5, 2016, 10:22 vorm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> lately the highlight color of plasma became a very washed-out blue, (since it switched to use the global system colors) that was because it actually taken the highlight color (and highlightedText) from the wrong source.
> there is a correct color group in kcolorscheme for that, that is Selection, take those two colors from that (also means highlight and highlightedtext always be the same in all plasma::theme::colorgroups but that's not a problem)
> 
> update test to reflect that
> 
> 
> Diffs
> -----
> 
>   autotests/themetest.cpp ce512a4 
>   src/declarativeimports/core/quicktheme.h ac5e121 
>   src/plasma/private/theme_p.h d2246de 
>   src/plasma/private/theme_p.cpp e6d55c3 
> 
> Diff: https://git.reviewboard.kde.org/r/127842/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160510/8b6aa977/attachment-0001.html>