Review Request 127888: use selected icon effect for current KPageView page

[Emmanuel Pescosta]

> On May 10, 2016, 5:17 p.m., Emmanuel Pescosta wrote:
> > src/kpageview_p.cpp, line 402
> > <https://git.reviewboard.kde.org/r/127888/diff/1/?file=464590#file464590line402>
> >
> >     option.state & (QStyle::State_Selected | QStyle::State_Active) maybe?
> 
> Marco Martin wrote:
>     doesn't work, if state is QStyle::State_Active, (QStyle::State_Active & (QStyle::State_Selected | QStyle::State_Active)) is QStyle::State_Active, not QStyle::State_None

Oh yes, sorry for the noise :/
You don't need a bit mask here of course.


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127888/#review95354
-----------------------------------------------------------


On May 10, 2016, 5:12 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127888/
> -----------------------------------------------------------
> 
> (Updated May 10, 2016, 5:12 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> in case icons of KPageView are monochromatic, recolor them of the highlightedtext color as the other patches on the breeze style and kio
> 
> 
> Diffs
> -----
> 
>   src/kpageview_p.cpp 650a7b3 
> 
> Diff: https://git.reviewboard.kde.org/r/127888/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> dadel3.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/10/72741885-021d-448f-892e-1590b95ef8c0__dadel3.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160510/beeba2cb/attachment.html>