[Differential] [Request, 9 lines] D1573: Destroy static Client helper window before application goes down

graesslin (Martin Gräßlin) noreply at phabricator.kde.org
Mon May 9 14:12:46 UTC 2016


graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Client uses a static Xcb::Window helper. This so far didn't get
  explicitly destroyed, so the application finalize cleaned it up.
  To destroy the window the xcb_connection_t* is used which the
  QGuiApplication already destroyed.
  
  This change ensures that the window gets destroyed before the xcb
  connection gets destroyed.
  
  In addition an assert is added to KWin::connection() to ensure that
  we still have the QGuiApplication::instance() when it's invoked.
  This way we'll notice if we have more cases where we call into xcb
  after the application went down.

REPOSITORY
  rKWIN KWin

BRANCH
  cleanup-x11

REVISION DETAIL
  https://phabricator.kde.org/D1573

AFFECTED FILES
  client.cpp
  client.h
  libkwineffects/kwinglobals.h
  workspace.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160509/7cc0af36/attachment-0001.html>


More information about the Plasma-devel mailing list