Review Request 127862: Keep a reference to the Solid::Device whilst we are using the Solid::Device interface

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127862/
-----------------------------------------------------------

(Updated May 8, 2016, 5:56 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 95569a0eae884427c7f7ab11fd63ae577f0be16d by David Edmundson to branch Plasma/5.6.


Repository: kinfocenter


Description
-------

Otherwise we were effectively relying on Solid's cache for memory
management.

This led to a problem that QML's QObject wrapper would detect the
Solid::Battery was being deleted on shutdown, and re-evaluate
currentBattery. This would then call BatteryModel.fetch(0) which being
slightly behind would then return an invalid object.

This ensure items get deleted in the correct order.

BUG: 350861


Diffs
-----

  Modules/energy/batterymodel.h c319d197b7cab1bed67151db65193bc5bcb24e2b 
  Modules/energy/batterymodel.cpp 7eade5498eda18ee0cfccddec70d5900c4eb2c96 

Diff: https://git.reviewboard.kde.org/r/127862/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160508/7afc1414/attachment.html>