Review Request 127862: Keep a reference to the Solid::Device whilst we are using the Solid::Device interface

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127862/#review95271
-----------------------------------------------------------



+1

- Mark Gaiser


On mei 7, 2016, 8:13 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127862/
> -----------------------------------------------------------
> 
> (Updated mei 7, 2016, 8:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> -------
> 
> Otherwise we were effectively relying on Solid's cache for memory
> management.
> 
> This led to a problem that QML's QObject wrapper would detect the
> Solid::Battery was being deleted on shutdown, and re-evaluate
> currentBattery. This would then call BatteryModel.fetch(0) which being
> slightly behind would then return an invalid object.
> 
> This ensure items get deleted in the correct order.
> 
> BUG: 350861
> 
> 
> Diffs
> -----
> 
>   Modules/energy/batterymodel.h c319d197b7cab1bed67151db65193bc5bcb24e2b 
>   Modules/energy/batterymodel.cpp 7eade5498eda18ee0cfccddec70d5900c4eb2c96 
> 
> Diff: https://git.reviewboard.kde.org/r/127862/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160508/33238731/attachment.html>