Review Request 127848: Revert "Don't import an nonexistent layout"

David Rosca nowrep at gmail.com
Fri May 6 15:57:43 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127848/
-----------------------------------------------------------

(Updated May 6, 2016, 3:57 p.m.)


Status
------

This change has been discarded.


Review request for Plasma and Aleix Pol Gonzalez.


Bugs: 360777
    http://bugs.kde.org/show_bug.cgi?id=360777


Repository: plasma-framework


Description
-------

importLayout is not called when started from SDDM which results in startupCompleted not being emitted and splash waiting for timeout.

This reverts commit 309c64f5e90453c5253baf19e6c01759e8aa6f83.


Diffs
-----

  src/plasma/corona.cpp 1784516 

Diff: https://git.reviewboard.kde.org/r/127848/diff/


Testing
-------

No more splash timeouts. 
For plasmashell tests, the startupCompleted is emitted 2 times, so tests run 4 times too (twice for each startupCompleted signal..).


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160506/acbd04af/attachment-0001.html>


More information about the Plasma-devel mailing list