Review Request 127794: [Comic] Plasmoid icon is placed in plasmoid content

[Anthony Fieroni]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127794/
-----------------------------------------------------------

(Updated May 4, 2016, 7:35 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Marco Martin.


Changes
-------

Submitted with commit e3614f9ab82ca3b87de7db9d3abbf593ce6ab04b by Anthony Fieroni to branch Plasma/5.6.


Bugs: 361928
    http://bugs.kde.org/show_bug.cgi?id=361928


Repository: kdeplasma-addons


Description
-------

Looks like a bug?
Plasmoid.icon: {
        iconSource: "face-laughing"
    }
Partial fix, if you resize plasmoid without load comic provider, plasmoid.icon fits content again :)


Diffs
-----

  applets/comic/package/contents/ui/main.qml 2834f7f 

Diff: https://git.reviewboard.kde.org/r/127794/diff/


Testing
-------

+ Remove highlightMask, it's look outdated and unusable (selected tab is underlined)
+ Don't show image content when add provider(s) and then removes all.


Thanks,

Anthony Fieroni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160504/d32c805a/attachment-0001.html>