Review Request 127794: [Comic] Plasmoid icon is placed in plasmoid content

Anthony Fieroni bvbfan at abv.bg
Wed May 4 17:00:40 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127794/
-----------------------------------------------------------

(Updated Май 4, 2016, 8 след обяд)


Review request for Plasma and Marco Martin.


Bugs: 361928
    http://bugs.kde.org/show_bug.cgi?id=361928


Repository: kdeplasma-addons


Description
-------

Looks like a bug?
Plasmoid.icon: {
        iconSource: "face-laughing"
    }
Partial fix, if you resize plasmoid without load comic provider, plasmoid.icon fits content again :)


Diffs (updated)
-----

  applets/comic/package/contents/ui/main.qml 2834f7f 

Diff: https://git.reviewboard.kde.org/r/127794/diff/


Testing
-------

+ Remove highlightMask, it's look outdated and unusable (selected tab is underlined)
+ Don't show image content when add provider(s) and then removes all.


Thanks,

Anthony Fieroni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160504/da8e7a6a/attachment.html>


More information about the Plasma-devel mailing list