Review Request 127781: Remove clearly broken code

Marco Martin notmart at gmail.com
Wed May 4 15:57:22 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127781/#review95173
-----------------------------------------------------------


Ship it!




let's kill it as wouldn't work, then let's rethink about it when/if something like that will be explicitly asked for by distributions

- Marco Martin


On April 28, 2016, 4:48 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127781/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 4:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-integration
> 
> 
> Description
> -------
> 
> This line never would have found anything and therefore clearly is not
> used and wasn't tested.
> 
> Even assuming there wasn't a typo, it's a hardcoded path and we don't
> install anything there.
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/khintssettings.cpp 5a40b91da691da3c0b599507098b655f4750a07e 
> 
> Diff: https://git.reviewboard.kde.org/r/127781/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160504/9cd2df09/attachment.html>


More information about the Plasma-devel mailing list