Review Request 127794: [Comic] Plasmoid icon is placed in plasmoid content

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127794/#review95171
-----------------------------------------------------------


Fix it, then Ship it!




it's ok, except line 45


applets/comic/package/contents/ui/main.qml (line 45)
<https://git.reviewboard.kde.org/r/127794/#comment64585>

    no, plasmoid.icon is just an icon name, this wouldn't work


- Marco Martin


On April 30, 2016, 1:46 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127794/
> -----------------------------------------------------------
> 
> (Updated April 30, 2016, 1:46 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Bugs: 361928
>     http://bugs.kde.org/show_bug.cgi?id=361928
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Looks like a bug?
> Plasmoid.icon: {
>         iconSource: "face-laughing"
>     }
> Partial fix, if you resize plasmoid without load comic provider, plasmoid.icon fits content again :)
> 
> 
> Diffs
> -----
> 
>   applets/comic/package/contents/ui/main.qml 2834f7f 
> 
> Diff: https://git.reviewboard.kde.org/r/127794/diff/
> 
> 
> Testing
> -------
> 
> + Remove highlightMask, it's look outdated and unusable (selected tab is underlined)
> + Don't show image content when add provider(s) and then removes all.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160504/65e17c82/attachment-0001.html>