Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127702/
-----------------------------------------------------------

(Updated May 4, 2016, 3:36 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit f336f800393a2d8081d22a72da30701609ac977d by David Rosca to branch master.


Repository: plasma-framework


Description
-------

ConfigModel may contain ConfigCategory for both QML pages and KCM pages. The source property will be empty for KCM pages.
This fixes correctly returning empty source for KCM pages. Also return the same value from get().


Diffs
-----

  autotests/CMakeLists.txt 747e8e0 
  autotests/configmodeltest.h PRE-CREATION 
  autotests/configmodeltest.cpp PRE-CREATION 
  autotests/data/testconfigpackage/contents/config/config.qml PRE-CREATION 
  autotests/data/testconfigpackage/contents/config/main.xml PRE-CREATION 
  autotests/data/testconfigpackage/contents/ui/ConfigGeneral.qml PRE-CREATION 
  autotests/data/testconfigpackage/contents/ui/main.qml PRE-CREATION 
  autotests/data/testconfigpackage/metadata.desktop PRE-CREATION 
  src/plasmaquick/configmodel.cpp 3f69073 

Diff: https://git.reviewboard.kde.org/r/127702/diff/


Testing
-------

Added qml config page to plasma-pa, KCM page now works fine.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160504/60d6fcac/attachment.html>